IAM 597 #39
Draft
IAM 597 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shipperizer
force-pushed
the
IAM-597
branch
2 times, most recently
from
e0402b1
to
7c336f4
Compare
shipperizer
force-pushed
the
IAM-597
branch
2 times, most recently
from
c16748e
to
4259372
Compare
nsklikas
force-pushed
the
IAM-597
branch
2 times, most recently
from
179654d
to
4e82701
Compare
nsklikas
reviewed
Mar 29, 2024
| AuthURL: specs.AuthURL, | ||
| TokenURL: specs.TokenURL, | ||
| DeviceAuthURL: specs.DeviceAuthURL, | ||
| AuthStyle: oauth2.AuthStyleInHeader, |
There was a problem hiding this comment.
This is needed because otherwise the go client will try to hit the token endpoint again when it gets an authorization_pending response. The reason for this is that if no client authn method is specified, the client will try to hit the token endpoint with another auth method if it gets a token endpoint error. The problem is that it does not parse the error code to validate that the error was caused by a client_authn_failed.
shipperizer
force-pushed
the
IAM-597
branch
2 times, most recently
from
583dceb
to
f0fb12f
Compare
This commit includes a bunch of changes: - Specify 8443 port - Automatically create the Hydra client if no client_id is provided - Do not start server in go code - Clean up messages - Set log level for login UI to info
- Point to canonical hydra repo - Pin contour version
This is needed because if the method is not specified, the go client will try to hit the token endpoint again, but with a different client authn method if the first one fails. The problem is that the go client does not try to parse the error it got from the provider, which in the device flow most of the time will be authorization_pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##################################
To give it a shot:
sudo lxc config set core.https_address :8444 && sudo snap restart lxdhack/helm/kratos.yamldevMakefile target withmake dev